Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

From: Shawn Guo
Date: Mon Feb 11 2019 - 00:39:58 EST


On Mon, Feb 11, 2019 at 02:53:18AM +0000, Peng Ma wrote:
>
>
> >-----Original Message-----
> >From: Shawn Guo <shawnguo@xxxxxxxxxx>
> >Sent: 2019å2æ1æ 14:30
> >To: Peng Ma <peng.ma@xxxxxxx>
> >Cc: axboe@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; Leo Li
> ><leoyang.li@xxxxxxx>; linux-ide@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> >linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Andy Tang
> ><andy.tang@xxxxxxx>
> >Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support
> >
> >On Fri, Jan 25, 2019 at 08:10:13AM +0000, Peng Ma wrote:
> >> Add SATA device nodes for fsl-lx2160a and enable support for QDS and
> >> RDB boards.
> >>
> >> Signed-off-by: Peng Ma <peng.ma@xxxxxxx>
> >> ---
> >> changed for V5:
> >> - no change
> >>
> >> arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++++++
> >> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++
> >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44
> >+++++++++++++++++++++
> >> 3 files changed, 76 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> >> index 99a22ab..1a5acf6 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> >> @@ -95,6 +95,22 @@
> >> };
> >> };
> >>
> >> +&sata0 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata2 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata3 {
> >> + status = "okay";
> >> +};
> >> +
> >> &uart0 {
> >> status = "okay";
> >> };
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> >> index 6481e5f..5b6799e 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> >> @@ -102,6 +102,22 @@
> >> };
> >> };
> >>
> >> +&sata0 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata2 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&sata3 {
> >> + status = "okay";
> >> +};
> >> +
> >> &uart0 {
> >> status = "okay";
> >> };
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> index a79f5c1..592034b 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >> @@ -671,6 +671,50 @@
> >> status = "disabled";
> >> };
> >>
> >> + sata0: sata@3200000 {
> >> + compatible = "fsl,lx2160a-ahci";
> >
> >Has the kernel driver been patched to probe the compatible?
> >
> >Shawn
> Yes, the driver patch is http://patchwork.ozlabs.org/patch/1034083/

Ping me when the driver patch is accepted. Ideally, we only accept dts
changes after the driver counterpart lands on mainline.

Shawn