Re: [PATCH 4.20 066/352] ASoC: sunxi: sun50i-codec-analog: Add support for cpvdd regulator supply

From: Greg Kroah-Hartman
Date: Mon Feb 11 2019 - 12:12:40 EST


On Mon, Feb 11, 2019 at 04:58:39PM +0000, Mark Brown wrote:
> On Mon, Feb 11, 2019 at 05:50:08PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Feb 11, 2019 at 02:39:24PM +0000, Mark Brown wrote:
>
> > > This is more a new feature than a bug fix, it doesn't look like obvious
> > > stable material.
>
> > Normally we take "new quirks and device ids", and given that this is a
> > tiny 2 line patch, that seems to fit that requirement.
>
> It's definitely not a quirk, it's changing from completely ignoring a
> supply to actively managing it at runtime which if it has any effect on
> existing systems is more likely to break something than fix it. It's
> not like the fixes for build problems which can't be triggered in old
> kernels, it'll start us things we never used to do.

Ok, that's fair enough, now dropped.

greg k-h