Re: [PATCH] gpio: sprd: Add missing break in switch statement

From: Gustavo A. R. Silva
Date: Mon Feb 11 2019 - 21:11:19 EST


Hi Baolin,

On 2/11/19 8:07 PM, Baolin Wang wrote:
> Hi Gustavo,
>
> On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>>
>> Fix the following warning by adding a missing break:
>>
>> drivers/gpio/gpio-eic-sprd.c: In function âsprd_eic_irq_set_typeâ:
>> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (flow_type) {
>> ^~~~~~
>> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
>> default:
>> ^~~~~~~
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Thanks for fixing my mistake.
> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>

Glad to help. :)

Thanks
--
Gustavo