Re: [PATCH 4.9 034/137] ARM: mmp/mmp2: dt: enable the clock

From: Greg Kroah-Hartman
Date: Tue Feb 12 2019 - 03:57:07 EST


On Mon, Feb 11, 2019 at 09:51:25PM +0100, Pavel Machek wrote:
> Hi!
>
> > 4.9-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > [ Upstream commit f36797ee43802b367e59f0f9a9805304a4ff0c98 ]
> >
> > The device-tree booted MMP2 needs to enable the timer clock, otherwise
> > it would stop ticking when the boot finishes.
> >
> > It can also use the clock rate from the clk, the non-DT boards need to
> > keep using the hardcoded rates.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> > Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> While I agree this is good idea for mainline (thus my ack), I don't
> think it is suitable for stable, as older kernels will not run on OLPC
> in useful way, anyway.
>
> Not-acked-for-stable-by: Pavel Machek <pavel@xxxxxx>
>
> So I don't think this and ARM: dts: mmp2: fix TWSI2 is good idea for
> stable kernels.

Ok, I'll drop this, and the follow-on patch that fixed this one up, from
all queues.

thanks,

greg k-h