Re: [PATCH v3 10/11] input: max77650: add onkey support

[Pavel Machek]

On Tue 2019-02-12 14:29:49, Bartosz Golaszewski wrote:
> wt., 12 lut 2019 o 13:17 Pavel Machek <pavel@xxxxxx> napisaÅ(a):
> >
> > Hi!
> >
> > > +     error = device_property_read_string(dev,
> > > +                                         "maxim,onkey-mode", &mode_prop);
> > > +     if (error)
> > > +             mode_prop = "push";
> > > +
> > > +     if (strcmp(mode_prop, "push") == 0)
> > > +             mode = MAX77650_ONKEY_MODE_PUSH;
> > > +     else if (strcmp(mode_prop, "slide") == 0)
> > > +             mode = MAX77650_ONKEY_MODE_SLIDE;
> > > +     else
> > > +             return -EINVAL;
> > ...
> > > +     onkey->input->name = "max77650_onkey";
> > > +     onkey->input->phys = "max77650_onkey/input0";
> > > +     onkey->input->id.bustype = BUS_I2C;
> > > +     input_set_capability(onkey->input, EV_KEY, onkey->code);
> >
> > Is EV_KEY correct for mode==slide?
> >
> 
> Others are not really documented. Does EV_SW stand for switch event?
> In that case it would probably be better.

I believe so.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature