Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

From: Jim Mattson
Date: Tue Feb 12 2019 - 13:01:14 EST


On Tue, Feb 12, 2019 at 6:16 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 07/02/19 22:17, Jim Mattson wrote:
> >> SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If
> >> (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that
> >> some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6,
> >> model: 0xf, stepping: 0x6") don't have it. Add the missing check.
> >>
> >> Reported-by: Zdenek Kaspar <zkaspar82@xxxxxxxxx>
> >> Tested-by: Zdenek Kaspar <zkaspar82@xxxxxxxxx>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> >
> > Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>
>
> Queued, thanks.
>
> Paolo

Alternatively, rdmsr could be changed to rdmsr_safe.