Re: [PATCH] lib/string: add memrchr function

From: Greg KH
Date: Tue Feb 12 2019 - 14:15:41 EST


On Wed, Feb 13, 2019 at 03:09:19AM +0800, xiang xiao wrote:
> On Wed, Feb 13, 2019 at 2:34 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Feb 13, 2019 at 02:06:49AM +0800, Xiang Xiao wrote:
> > > Here is the detailed description for memrchr:
> > > https://linux.die.net/man/3/memrchr
> >
> > Please put it in the changelog, as web pages move and go away :(
>
> Sure.
>
> >
> > >
> > > Signed-off-by: Xiang Xiao <xiaoxiang@xxxxxxxxxx>
> > > ---
> > > include/linux/string.h | 1 +
> > > lib/string.c | 21 +++++++++++++++++++++
> > > 2 files changed, 22 insertions(+)
> > >
> > > diff --git a/include/linux/string.h b/include/linux/string.h
> > > index 7927b87..f380f4b 100644
> > > --- a/include/linux/string.h
> > > +++ b/include/linux/string.h
> > > @@ -167,6 +167,7 @@ static inline void memcpy_flushcache(void *dst, const void *src, size_t cnt)
> > > memcpy(dst, src, cnt);
> > > }
> > > #endif
> > > +void *memrchr(const void *s, int c, size_t n);
> >
> > Who is going to use this?
>
> This patch will use memrchr:
> https://github.com/thesofproject/linux/pull/177/commits/a0b7009fede5552dc98733f2996a8140bff62455
> I am preparing to upstream it.

Great, make it part of the patch series for your driver, no need to
submit it separately.

thanks,

greg k-h