Re: [PATCH] hwmon: (f71882fg) Mark expected switch fall-through

[Gustavo A. R. Silva]

On 2/12/19 3:51 PM, Guenter Roeck wrote:
> On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/hwmon/f71882fg.c: In function âf71882fg_probeâ:
>> drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>     data->auto_point_temp_signed = 1;
>>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
>> drivers/hwmon/f71882fg.c:2459:3: note: here
>>    case f71889fg:
>>    ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> 
> Applied to hwmon-next.
> 

Thanks, Guenter.

--
Gustavo