RE: [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter

From: Anup Patel
Date: Wed Feb 13 2019 - 01:05:32 EST




> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Wednesday, February 13, 2019 11:25 AM
> To: Anup Patel <Anup.Patel@xxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>; Anup Patel
> <anup@xxxxxxxxxxxxxx>; Palmer Dabbelt <palmer@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Atish Patra <Atish.Patra@xxxxxxx>; Albert Ou
> <aou@xxxxxxxxxxxxxxxxx>; Paul Walmsley <paul.walmsley@xxxxxxxxxx>;
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter
>
> On Wed, Feb 13, 2019 at 03:43:06AM +0000, Anup Patel wrote:
> > Sure, the keepinitrd=0 by default so it will always free-up initrd by default.
> > Please look at v3 patchset.
> >
> > Of course, we need separate patch to update documentation of
> keepinitrd.
>
> No, we need to not just blindly copy what arm did for historic reasons unless
> we have a very good reason of our own.
>
> In addition to not having a real need for any of this in a new setup, it also is
> duplicated by the retain_initrd parameter which is implemented in generic
> code - and for that the commit message at least has a rationale related to
> kexec:
>
> https://lkml.org/lkml/2006/12/7/15

Sure, I will re-work this patch to always free-up initrd.

Regards,
Anup