Re: [PATCH 1/5] tpm: Copy calc_tpm2_event_size() to TPM library

From: Jarkko Sakkinen
Date: Wed Feb 13 2019 - 06:18:17 EST


On Wed, Feb 13, 2019 at 01:14:43PM +0200, Jarkko Sakkinen wrote:
> On Mon, Feb 11, 2019 at 03:30:48PM +0100, bsz@xxxxxxxxxxxx wrote:
> > From: Bartosz Szczepanek <bsz@xxxxxxxxxxxx>
> >
> > Function to calculate event size in TPM 2.0 log will also be needed in EFI
> > stub. Separate it to library to make it accessible out of TPM character
> > driver.
> >
> > It will be removed from tpm2.c in subsequent commit.
> >
> > Signed-off-by: Bartosz Szczepanek <bsz@xxxxxxxxxxxx>
>
> Collides with Matthew's patch set, which has priority over this because
> it was sent earlier.
>
> Matthew, what you think of this? Maybe could replace 1/4 with this in
> your patch set? Somehow feels a bit cleaner approach.

This commit is in any case broken. It leaves two versions of the
function hanging to the code base.

/Jarkko