RE: [PATCH v5 1/6] RISC-V: Move free_initrd_mem() to kernel/setup.c

From: Anup Patel
Date: Wed Feb 13 2019 - 06:24:15 EST




> -----Original Message-----
> From: Mike Rapoport [mailto:rppt@xxxxxxxxxxxxx]
> Sent: Wednesday, February 13, 2019 3:30 PM
> To: Anup Patel <Anup.Patel@xxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxx>; Albert Ou
> <aou@xxxxxxxxxxxxxxxxx>; Atish Patra <Atish.Patra@xxxxxxx>; Paul
> Walmsley <paul.walmsley@xxxxxxxxxx>; Christoph Hellwig
> <hch@xxxxxxxxxxxxx>; linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 1/6] RISC-V: Move free_initrd_mem() to
> kernel/setup.c
>
> On Wed, Feb 13, 2019 at 08:07:17AM +0000, Anup Patel wrote:
> > We move free_initrd_mem() to kernel/setup.c so that all initrd related
> > functions are in one place.
>
> A few patches after you move setup_bootmem() that calls setup_initrd() to
> mm/init.c. I'd say it makes more sense to move setup_intird() to mm/init.c.

Makes sense. I will drop this patch and I will move setup_initrd() to
mm/init.c along with setup_bootmem() because setup_bootmem()
depends on setup_initrd().

Regards,
Anup