Re: [PATCH 2/2] gpio: sprd: Change to use SoC compatible string

From: Baolin Wang
Date: Wed Feb 13 2019 - 08:15:06 EST


On Wed, 13 Feb 2019 at 20:59, Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
>
> År., 13 lut 2019 o 13:49 Baolin Wang <baolin.wang@xxxxxxxxxx> napisaÅ(a):
> >
> > Change to use SoC compatible string instead of wildcard string.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> > ---
> > drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> > index ac573da..24228cf 100644
> > --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> > @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
> > }
> >
> > static const struct of_device_id sprd_pmic_eic_of_match[] = {
> > - { .compatible = "sprd,sc27xx-eic", },
> > + { .compatible = "sprd,sc2731-eic", },
> > { /* end of list */ }
> > };
> > MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> > --
> > 1.7.9.5
> >
>
> We guarantee to make older device-trees to work with new kernel so you
> can add the new compatible, but you can't remove the old one.

But the old one is incorrect, and we still keep it?

--
Baolin Wang
Best Regards