Re: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()

From: Christoph Hellwig
Date: Wed Feb 13 2019 - 12:54:20 EST


On Wed, Feb 13, 2019 at 09:38:36AM +0200, Mike Rapoport wrote:
> memblock_free() is has no real effect at this point, no idea why arm64
> calls it.

Looks like the call was added fairly recently by:

commit 05c58752f9dce11e396676eb731a620541590ed0
Author: CHANDAN VN <chandan.vn@xxxxxxxxxxx>
Date: Mon Apr 30 09:50:18 2018 +0530

arm64: To remove initrd reserved area entry from memblock

which claims it is to work around the initrd being displayed in
/sys/kernel/debug/memblock/reserved.

I really think we need to have common behavior there - either do this
for all architectures or none. I've just sent a series that
consolidates all but a handful of the free_initrd_mem, so implementing
any common behavior on top of that would be good.