Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

[Joe Perches]

On Thu, 2019-02-14 at 09:11 +0530, Vaishali Thakkar wrote:
> The Qualcomm socinfo provides a number of additional attributes,
> add these to the socinfo driver and expose them via debugfs
> functionality.

trivia:

> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
[]
> @@ -70,6 +93,10 @@ struct socinfo {
>  struct qcom_socinfo {
>  	struct soc_device *soc_dev;
>  	struct soc_device_attribute attr;
> +	#ifdef CONFIG_DEBUG_FS
> +	struct dentry *dbg_root;
> +	#endif /* CONFIG_DEBUG_FS */

It's generally better to move the #ifdef/#endif to column 1