Re: [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused node

From: agajjar
Date: Sat Feb 16 2019 - 10:39:03 EST

On 2/16/2019 2:16 AM, Heiko StÃbner wrote:
Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar:
On 2/15/2019 2:48 PM, Heiko StÃbner wrote:
Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar:
lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no
so removing it.

Signed-off-by: Akash Gajjar <Akash_Gajjar@xxxxxxxxxx>
Hi Heiko,

vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around
for completenes sake.
Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8

So I believe removing vcc1v8_s3 has no impact on emmc supply line.
looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked
to the emmc_vdd_1v8 input and obviously also as reference for the saradc.

You are referring Pilot production release (rockpro64_v20-SCH.pdf), please refer Second batch production release (rockpro64_v21-SCH.pdf).

both the schematic release is available at

So I think we really could keep it around, so that the power-tree resembles
the schematics more.