Re: [PATCH] ASoC: samsung: i2s: Prevent potential NULL platform data dereference

From: Krzysztof Kozlowski
Date: Mon Feb 18 2019 - 03:25:11 EST


On Thu, 14 Feb 2019 at 16:58, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
>
> When np is NULL i2s_pdata could also be NULL but i2s_pdata is now being
> dereferenced without proper check. Fix this and shorten the error message
> so we don't exceed 80 characters limit.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> ---
> sound/soc/samsung/i2s.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof