Re: [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

From: Sylwester Nawrocki
Date: Mon Feb 18 2019 - 06:04:54 EST


On 2/16/19 02:20, Wei Yongjun wrote:
> In case of error, the function platform_device_register_simple() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().

Thanks for the patch, it looks good but I have already prepared other
fix that removes the platform_device_register_simple() call entirely:

"ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization"
https://www.spinics.net/lists/kernel/msg3045092.html

--
Thanks,
Sylwester