RE: [PATCH] media: atmel: atmel-isc: reworked driver and formats
From: Ken Sloat
Date: Mon Feb 18 2019 - 08:37:33 EST
> -----Original Message-----
> From: Eugen.Hristev@xxxxxxxxxxxxx <Eugen.Hristev@xxxxxxxxxxxxx>
> Sent: Friday, February 15, 2019 3:38 AM
> To: linux-media@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; mchehab@xxxxxxxxxx;
> Nicolas.Ferre@xxxxxxxxxxxxx; Ken Sloat <KSloat@xxxxxxxxxxxxxx>;
> sakari.ailus@xxxxxx; hverkuil@xxxxxxxxx
> Cc: Eugen.Hristev@xxxxxxxxxxxxx
> Subject: [PATCH] media: atmel: atmel-isc: reworked driver and formats
> From: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> This change is a redesign in the formats and the way the ISC is configured
> w.r.t. sensor format and the output format from the ISC.
> I have changed the splitting between sensor output (which is also ISC input)
> and ISC output.
> The sensor format represents the way the sensor is configured, and what ISC
> is receiving.
> The format configuration represents the way ISC is interpreting the data and
> formatting the output to the subsystem.
> Now it's much easier to figure out what is the ISC configuration for input, and
> what is the configuration for output.
> The non-raw format can be obtained directly from sensor or it can be done
> inside the ISC. The controller format list will include a configuration for each
> The old supported formats are still in place, if we want to dump the sensor
> format directly to the output, the try format routine will detect and configure
> the pipeline accordingly.
> This also fixes the previous issues when the raw format was NULL which
> resulted in many crashes for sensors which did not have the expected/tested
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> Hello Ken and possibly others using ISC driver,
> I would appreciate if you could test this patch with your sensor, because I do
> not wish to break anything in your setups.
> Feedback is appreciated if any errors appear, so I can fix them.
> I tested with ov5640, ov7670, ov7740(only in 4.19 because on latest it's
> broken for me...) Rebased this patch on top of mediatree.git/master Thanks!
No problem I will try to test sometime this week on my setup. I appreciate you keeping me in the loop.