Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

[Gustavo A. R. Silva]

Hi Sasha,

On 2/18/19 3:14 PM, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver.
> 
> The bot has tested the following trees: v4.20.8, v4.19.21, v4.14.99, v4.9.156, v4.4.174, v3.18.134.
> 
> v4.20.8: Build OK!
> v4.19.21: Build OK!
> v4.14.99: Build OK!
> v4.9.156: Build OK!
> v4.4.174: Failed to apply! Possible dependencies:
>     01ead0ded315 ("staging: comedi: ni_660x: cleanup the NI660X_IO_CFG register helpers")
>     22acd860137a ("staging: comedi: ni_660x: change IOConfigReg() into a macro")
>     41014593caeb ("staging: comedi: ni_660x: cleanup the NI660X_GLOBAL_INT_{STATUS, CFG}")
>     502552e161ae ("staging: comedi: ni_660x: remove enum clock_config_register_bits")
>     518d38423b48 ("staging: comedi: ni_660x: tidy up ni_660x_select_pfi_output()")
>     9678b73e273a ("staging: comedi: ni_660x: tidy up ni_660x_write_register()")
>     aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
>     ad98c18cb9de ("staging: comedi: ni_660x: tidy up ni_660x_read_register()")
>     cded944fa90c ("staging: comedi: ni_660x: Prefer kernel type 'u64' over 'uint64_t'")
>     fecf4cce0021 ("staging: comedi: ni_660x: cleanup the NI660X_DMA_CFG register helpers")
> 
> v3.18.134: Failed to apply! Possible dependencies:
>     01ead0ded315 ("staging: comedi: ni_660x: cleanup the NI660X_IO_CFG register helpers")
>     22acd860137a ("staging: comedi: ni_660x: change IOConfigReg() into a macro")
>     41014593caeb ("staging: comedi: ni_660x: cleanup the NI660X_GLOBAL_INT_{STATUS, CFG}")
>     502552e161ae ("staging: comedi: ni_660x: remove enum clock_config_register_bits")
>     518d38423b48 ("staging: comedi: ni_660x: tidy up ni_660x_select_pfi_output()")
>     9678b73e273a ("staging: comedi: ni_660x: tidy up ni_660x_write_register()")
>     aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
>     ad98c18cb9de ("staging: comedi: ni_660x: tidy up ni_660x_read_register()")
>     cded944fa90c ("staging: comedi: ni_660x: Prefer kernel type 'u64' over 'uint64_t'")
>     fecf4cce0021 ("staging: comedi: ni_660x: cleanup the NI660X_DMA_CFG register helpers")
> 
> 
> How should we proceed with this patch?
> 

Ian commented that this bug was introduced in 4.7, so it should be applied to 4.9 ... 4.20

Thanks
--
Gustavo