Re: [PATCH v2 14/15] ARM: configs: Add Milbeaut M10V defconfig

From: Sugaya, Taichi
Date: Mon Feb 18 2019 - 22:15:17 EST


Thank you for comments.

On 2019/02/18 21:06, Arnd Bergmann wrote:
On Fri, Feb 8, 2019 at 1:30 PM Sugaya Taichi
<sugaya.taichi@xxxxxxxxxxxxx> wrote:

This patch adds the minimal defconfig for the Milbeaut M10V.

Signed-off-by: Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx>
arch/arm/configs/milbeaut_m10v_defconfig | 366 +++++++++++++++++++++++++++++++
1 file changed, 366 insertions(+)

I think it would be good to reduce this a little bit. Please also add any
options you need for booting to multi_v7_defconfig. Device drivers you
don't need for booting but for additional features should be loadable
modules there.

Yeah, I should have refined more.
OK, add aome options to multi_v7_defconfig also.


CONFIG_EMBEDDED should not normally be set on device
configurations. Despite the name it's not something for general
embedded computing, but it's rather an option that lets you
turn other option that one should normally not have to change.

OK, drop it.


Oprofile is rarely used these days, maybe change the default to

I see.
I try to use PERF_EVENTS instead.


I think this will be the first armv8-a platform with thumb2 by default,
and it's probably a good thing to start testing that more.

I still leave it in the next patch.


It's unusual to have both VMSPLIT_2G and HIGHMEM.

OK. try to drop either.


If you are able to fix the boot loaders, this should be turned off

The boot loader is fixed, so I think it can be turned off.


That seems like more debugging that you should need.

Yes, drop entirely.

+# CONFIG_I2C is not set
+# CONFIG_I2C_BOARDINFO is not set
+# CONFIG_I2C_COMPAT is not set
+# CONFIG_I2C_CHARDEV is not set
+# CONFIG_I2C_MUX is not set
+# CONFIG_I2C_HELPER_AUTO is not set
+# CONFIG_I2C_ALGOBIT is not set
+# CONFIG_I2C_SNI_M10V is not set

If I2C is disabled, you shoulnd't need any of the later
options here.

I2C is disable now... drop entirely.

+# CONFIG_VGA_ARB is not set

Since you don't have a framebuffer driver, and likely won't
add one (new drivers should use drivers/gpu/drm), I'd drop

framebuffer is disable too... drop it.

+# CONFIG_USB is not set
+# CONFIG_USB_MON is not set
+# CONFIG_USB_XHCI_HCD is not set
+# CONFIG_USB_EHCI_HCD is not set
+# CONFIG_MMC is not set
+# CONFIG_MMC_SDHCI is not set
+# CONFIG_MMC_SDHCI_F_SDH30 is not set
+# CONFIG_MMC_SDHCI_F_EMMC50 is not set

Also for USB and MMC: if you don't have the subsystem, you
should not need to list the other options.

USB, MMC, and more peripherals are disable now.
I will drop them in the next patch.

+# CONFIG_RTC_HCTOSYS is not set
+# CONFIG_RTC_SYSTOHC is not set
+#CONFIG_PWM=y is not set
+# CONFIG_PWM_SYSFS is not set
+#CONFIG_PWM_M10V=y is not set

CONFIG_EXFAT does not exist in mainline kernels.

Yes. drop it.

+# CONFIG_TEST_IPCU_FS is not set

same for IPCU_FS, and probably a lot of other options.

I will check again for unnecessary options.

Sugaya Taichi


linux-arm-kernel mailing list