Re: [PATCH V2] 8250_pci.c change for fix hanging problem.

From: Greg KH
Date: Tue Feb 19 2019 - 04:23:34 EST


On Tue, Feb 19, 2019 at 04:50:31PM +0800, saumah wrote:
> 8250_pci.c change for fix hanging problem while suspend machine. 8250_pci.c support the same vendor id and device id definition as sunix multi-I/O card driver, when the sunix multi-io borad driver is installed,there are two drivers to support the same sunix multi-io card,it will cause operation error.
>
> Signed-off-by: saumah <saumah@xxxxxxxxx>
> ---
> 8250_pci.c | 163 +----------------------------------------------------
> 1 file changed, 1 insertion(+), 162 deletions(-)

You can't just delete a ton of code, you just broke a bunch of existing
devices out there :(

Also, the patch is at the wrong level of the kernel source tree, you
need to use your full name for author and signed-off-by, you forgot to
cc: the linux-serial mailing list, and you need to wrap your changelog
text properly.

Please look at Documentation/SubmittingPatches for how to do all of this
and then redo and resend the patch.

thanks,

greg k-h