Re: [PATCH v2 -next] btrfs: Remove unnecessary casts in btrfs_read_root_item
From: Dan Carpenter
Date: Wed Feb 20 2019 - 07:34:00 EST
On Wed, Feb 20, 2019 at 12:32:02PM +0000, YueHaibing wrote:
> There is a messy cast here:
> min_t(int, len, (int)sizeof(*item)));
> min_t() should normally cast to unsigned. It's not possible for
> "len" to be negative, but if it were then we definitely
> wouldn't want to pass negatives to read_extent_buffer(). Also there
> is an extra cast.
> This patch shouldn't affect runtime, it's just a clean up.
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
It wasn't really suggested by me... But I do think it's the right
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>