Re: [PATCH] net: dsa: add missing phy address offset

From: Andrew Lunn
Date: Wed Feb 20 2019 - 14:31:28 EST


On Wed, Feb 20, 2019 at 11:27:16AM -0800, Florian Fainelli wrote:
> On 2/20/19 10:15 AM, Marcel Reichmuth wrote:
> > When phys do not start at address 0 like on the mv88e6341 the wrong
> > phy address is used and therefore the slave ports can not be
> > initialized. This patch adds the proper offset to the phy address.
> >
> > Signed-off-by: Marcel Reichmuth <marcel.reichmuth@xxxxxxxxxxxxx>
>
> You are supposed to describe the port to PHY mapping using the binding,
> so for instance:
>
> ports {
> port@0 {
> reg = <0>;
> phy-handle = <&phy1>;
> };
>
> };
>
> mdio {
> phy1: phy@1 {
> reg = <1>;
> };
> };
>
> etc. is not that working for you?


The Espressobin does exactly this:

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts

It also uses the 6341.

Andrew