Re: [PATCH 4/6] lib/test_bitmap: switch test_bitmap_parselist to ktime_get()

From: Palmer Dabbelt
Date: Wed Feb 20 2019 - 18:10:48 EST

On Wed, 20 Feb 2019 06:20:48 PST (-0800), yury.norov@xxxxxxxxx wrote:
On Wed, Feb 20, 2019 at 03:52:36PM +0200, Andy Shevchenko wrote:
On Wed, Feb 20, 2019 at 03:51:01PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 20, 2019 at 11:37:03AM +0300, Yury Norov wrote:
> > test_bitmap_parselist currently uses get_cycles which is not
> > implemented on some platforms, so use ktime_get() instead.
> This sounds like a fix that should go first in the series.

Ah, okay, it's already first for test module.
Perhaps Fixes tag and actually one or more examples of such architectures?

Hi Andy, thanks for your time on it.

Only arm, arm64, openrisc, riscv and sparc64 #define get_cycles.
So IIUC, others take stub from include/asm-generic/timex.h.

Should we (RISC-V) be doing something else? It seems odd to be in such a minority here, but we do have a ISA-mandated timer so the get_cycles() implementation is super easy.

sparc32, xtensa, m68k, um, and in some cases x86, mips and nios2
provide zero-stubs explicitly.


With Best Regards,
Andy Shevchenko