Re: [RFC PATCH net-next v3 14/21] ethtool: provide link mode names as a string set

From: Michal Kubecek
Date: Thu Feb 21 2019 - 04:57:14 EST


On Wed, Feb 20, 2019 at 07:21:58PM -0800, Florian Fainelli wrote:
> > +const char *const link_mode_names[] = {
>
> Maybe you can define a macro (totally untested) to build the table an
> avoid some of the repetition, something like:
>
> #define ETHTOOL_LINK_NAME(speed, duplex) \
> [ETHTOOL_LINK_MODE_##speed_##duplex_BIT] = stringify(speed ## "/" ##
> duplex)

Thanks for the tip, that should work for most of the modes.

Michal