Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

From: kbuild test robot
Date: Thu Feb 21 2019 - 05:41:15 EST

Hi Nikolaus,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v5.0-rc4 next-20190220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

base: usb-testing
config: i386-randconfig-a0-201907 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

drivers/usb/typec/tps6598x.c: In function 'tps6598x_block_write':
>> drivers/usb/typec/tps6598x.c:132:2: warning: variable length array 'data' is used [-Wvla]
u8 data[len + 1];

vim +/data +132 drivers/usb/typec/tps6598x.c

129 static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
130 void *val, size_t len)
131 {
> 132 u8 data[len + 1];
134 if (!tps->i2c_protocol)
135 return regmap_raw_write(tps->regmap, reg, val, len);
137 data[0] = len;
138 memcpy(&data[1], val, len);
140 return regmap_raw_write(tps->regmap, reg, data, sizeof(data));
141 }

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation

Attachment: .config.gz
Description: application/gzip