Re: [PATCH] nvme-pci: Prevent mmio reads if pci channel offline

From: Linus Torvalds
Date: Fri Feb 22 2019 - 16:29:06 EST


On Thu, Feb 21, 2019 at 5:07 PM Jon Derrick <jonathan.derrick@xxxxxxxxx> wrote:
>
> Some platforms don't seem to easily tolerate non-posted mmio reads on
> lost (hot removed) devices. This has been noted in previous
> modifications to other layers where an mmio read to a lost device could
> cause an undesired firmware intervention [1][2].

This is broken, and whatever platform that requires this is broken.

This has absolutely nothing to do with nvme, and should not be handled
by a driver.

The platform code should be fixed.

What broken platform is this, and why is it causing problems?

None of this wishy-washy "some platforms". Name them, and let's get them fixed.

Linus