Re: [PATCH] checkpatch: don't complain about "undocumented" USB VID

From: Joe Perches
Date: Fri Feb 22 2019 - 19:52:34 EST


On Fri, 2019-02-22 at 14:55 -0800, Brian Norris wrote:
> Documentation/devicetree/bindings/usb/usb-device.txt describes the
> 'usbVID,...' compatible format, where VID is hexadecimal, with leading
> zeroes suppressed. Allow it here without complaining.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3012,6 +3012,8 @@ sub process {
> }
>
> next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
> + # USB VIDs don't need special vendor prefix documentation.
> + next if $compat =~ /^usb[1-9a-f][0-9a-f]{0,3},/;

Maybe check the PID too?

next if $compat =~ /^usb[1-9a-f][0-9a-f]{0,3},[1-9a-f][0-9a-f]{0,3}\b/;


Maybe add a test for uses of the leading 0?