Re: [PATCH 10/13] memory: mtk-smi: Get rid of mtk_smi_larb_get/put
From: Evan Green
Date: Mon Feb 25 2019 - 19:02:59 EST
On Mon, Dec 31, 2018 at 8:53 PM Yong Wu <yong.wu@xxxxxxxxxxxx> wrote:
> After adding device_link between the iommu consumer and smi-larb,
> the pm_runtime_get(_sync) of smi-larb and smi-common will be called
> automatically. we can get rid of mtk_smi_larb_get/put.
> CC: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
It's possible that there's so little left in mediatek/smi.h that it
could be deleted entirely and its last remaining bits absorbed into
other locations. But maybe it's nice to keep those last little bits
used by mtk-smi.c away from the iommu definitions. So it seems fine
as-is to me.
Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>