Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
From: Gustavo A. R. Silva
Date: Tue Feb 26 2019 - 12:46:14 EST
Who can take this?
On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
> On 2/18/19 10:09 AM, Guenter Roeck wrote:
>> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>> This patch fixes the following warning:
>>> drivers/watchdog/pc87413_wdt.c: In function âpc87413_ioctlâ:
>>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> ÂÂÂ pc87413_refresh();
>>> ÂÂÂ ^~~~~~~~~~~~~~~~~
>>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
>>> ÂÂ case WDIOC_GETTIMEOUT:
>>> ÂÂ ^~~~
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>> Notice that, in this particular case, the code comment is modified
>>> in accordance with what GCC is expecting to find.
>>> This patch is part of the ongoing efforts to enable
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Thanks, Guenter.