Re: [PATCH] x86/stacktrace: export save_stack_trace_tsk_reliable

From: Joe Lawrence
Date: Wed Feb 27 2019 - 18:20:18 EST

On 2/27/19 5:25 PM, Joe Lawrence wrote:
On 2/27/19 4:31 PM, Thomas Gleixner wrote:
On Wed, 27 Feb 2019, Joe Lawrence wrote:

The ppc64le implementation of save_stack_trace_tsk_reliable() is
exported, so do the same with x86.

And what's the in tree module user of this? I can't find one and just
because PPC has an export with no user is not a convincing argument to add
another one. The proper solution is to remove the unused PPC export.

Good point.

For that matter, I do see in-tree modules making use of
save_stack_trace, but who is calling save_stack_trace_tsk (exported by
most arches) and save_stack_trace_regs (exported by openrisc, powerpc,

Well, at least for save_stack_trace_tsk there is the out-of-tree kpatch core module[1]. (Kpatch drops that call if the kernel provides livepatch functionality.)


-- Joe