Re: [PATCH] tracing: Fix event filters and triggers to handle negative numbers
From: Steven Rostedt
Date: Thu Feb 28 2019 - 11:19:13 EST
On Thu, 28 Feb 2019 09:11:37 +0000
Pavel Tikhomirov <ptikhomirov@xxxxxxxxxxxxx> wrote:
> ping, looks like the patch was lost
> On 8/24/18 3:48 AM, Steven Rostedt wrote:
> > On Thu, 23 Aug 2018 13:25:34 +0300
> > Pavel Tikhomirov <ptikhomirov@xxxxxxxxxxxxx> wrote:
> >> Then tracing syscall exit event it is extremely useful to filter exit
> >> codes equal to some negative value, to react only to required errors.
> >> But negative numbers does not work:
> >> [root@snorch sys_exit_read]# echo "ret == -1" > filter
> >> bash: echo: write error: Invalid argument
> >> [root@snorch sys_exit_read]# cat filter
> >> ret == -1
> >> ^
> >> parse_error: Invalid value (did you forget quotes)?
> > Thanks for the patch. I'll apply it and then start testing it!
I remember applying this to my git queue (I don't reply like this
before doing so). Not sure how it got lost. All I can think of is that
it might have been added with commits that ended up failing the tests,
and got reverted with that code :-/
I'm currently traveling. Hopefully I remember tomorrow to add this.
Thanks for pointing this out, and I need to be a bit more careful when
reverting failed commits :-p