Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

From: Andrew Lunn
Date: Thu Feb 28 2019 - 11:37:50 EST


> Hi Andrew,
>
> we produce a lot of boards and we have to change the MAC address,
> from u-boot, for every board. So I must save in the u-boot
> environment (SPI NOR flash) the MAC address for every board.

Hi Flavio

u-boot should be able to write the MAC address in the correct part of
device tree. Boards have been doing this a long time.

Module parameters are considered bad. You should only do it if you
have no other option. Here you do have another options, so it is going
to be a hard sell getting David to access your patch.

You will have more success by adding a call to
eth_platform_get_mac_address() to the e1000e driver.

Andrew