Re: [PATCH net-next 2/6] net: 8021q: vlan_dev: add vid tag to addresses of uc and mc lists

[Ivan Khoronzhuk]

On Wed, Feb 27, 2019 at 08:09:44PM -0800, Florian Fainelli wrote:
> On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote:
> > Update vlan mc and uc addresses with VID tag while propagating
> > addresses to lower devices, do this only if address is not synced.
> > It allows at end driver level to distinguish addresses belonging
> > to vlan devices.
> >
> > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
> > ---
>
> [snip]
>
> > +u16 vlan_dev_get_addr_vid(struct net_device *dev, const u8 *addr)
>
> Having some kernel doc comment here would also be nice.

yes can be: vlan_dev_get_addr_vid - get vlan id the address belongs to


> > +{
> > +	u16 vid = 0;
> > +
> > +	if (dev->vid_len != NET_8021Q_VID_TSIZE)
> > +		return vid;
> > +
> > +	vid = addr[dev->addr_len];
> > +	vid |= (addr[dev->addr_len + 1] & 0xf) << 8;
>
> This uses knowledge of the maximum VLAN ID is 4095, which is fine, might
> be a good idea to add a check on VID not exceeding the maximum VLAN ID
> number instead of doing a silent truncation?

and then return -1, not sure, just because it's 0 or directly set by vlan
layer and is verified anyway. But no harm to verify even it looks like
redundancy.

> [snip]
>
> > +static void vlan_dev_align_addr_vid(struct net_device *vlan_dev)
> > +{
> > +	struct net_device *real_dev = vlan_dev_real_dev(vlan_dev);
> > +	struct netdev_hw_addr *ha;
> > +
> > +	if (!real_dev->vid_len)
> > +		return;
>
> Should not this check be moved to dev_{mc,uc}_sync? It does not seem to
> me like this would scale really well across different stacked devices
> (VLAN, bond, macvlan) as well as underlying drivers (cpsw, dsa, etc.).
> Or maybe the check should be if vlan_dev->vid_len > real_dev->vid_len ->
> error, right?

It shouldn't be part of netdev addr module, no any vlan_dev_vlan_id(vlan_dev)
should be there.

It's scaled becouse bond/team ...etc, are ethernet devices and have IVDF
enabled while configuration. Address propagation always is from leafs to
real root device, every underneeth device knows nothing about above, so
check is only in one direction.

--
Regards,
Ivan Khoronzhuk