Re: [PATCH 1/2] gcc-plugins: structleak: Generalize to all variable types

From: Kees Cook
Date: Sat Mar 02 2019 - 10:43:45 EST

On Sat, Mar 2, 2019 at 1:05 AM Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
> On Thu, 28 Feb 2019 at 21:27, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > I get similar results with asan-stack=1 but without your plugin, only
> > the combination of the two has the explosive stack size growth.

I can look more closely, but I'm not sure it's entirely worth it:
these two may not make sense to build at the same time. (e.g. the
use-after-scope config was disallowed to work with this plugin.)

> > I can help analyze this further, but maybe you can have a look first,
> > there might be something obvious when you read the input to the
> > plugin.
> >
> Is this before or after use-after-scope was disabled entirely?

I was wondering the same thing, but I assumed it didn't matter: it
wasn't possible to use both before it was entirely disabled.

Kees Cook