Re: [PATCH] iwlwifi: fix 64-bit division
From: Luciano Coelho
Date: Tue Mar 05 2019 - 01:44:01 EST
On Mon, 2019-03-04 at 21:38 +0100, Arnd Bergmann wrote:
> do_div() expects unsigned operands and otherwise triggers a warning
> drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2: error:
> comparison of distinct pointer types ('typeof ((rtt_avg)) *' (aka
> 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-
> do_div(rtt_avg, 6666);
> include/asm-generic/div64.h:222:28: note: expanded from macro
> (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
> ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
> 1 error generated.
> Change the do_div() to the simpler div_s64() that can handle
> negative inputs correctly.
> Fixes: 937b10c0de68 ("iwlwifi: mvm: add debug prints for FTM")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
This was already fixed with this patch:
...but it hasn't reached the mainline yet.
I'm planning to send it to the v5.1-rc series as soon as the merge
window closes. Is that quick enough for you?