Re: [PATCH 3/5] mmc: mmci: qcom: define get_dctrl_cfg

From: Ulf Hansson
Date: Wed Mar 06 2019 - 08:32:22 EST


On Mon, 4 Mar 2019 at 11:17, Ludovic Barre <ludovic.Barre@xxxxxx> wrote:
>
> From: Ludovic Barre <ludovic.barre@xxxxxx>
>
> This patch defines get_dctrl_cfg callback for qcom variant.
> qcom variant has a specific block size definition.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx>
> ---
> drivers/mmc/host/mmci_qcom_dml.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
> index 25d0a75..d7b083d 100644
> --- a/drivers/mmc/host/mmci_qcom_dml.c
> +++ b/drivers/mmc/host/mmci_qcom_dml.c
> @@ -183,9 +183,17 @@ static int qcom_dma_setup(struct mmci_host *host)
> return 0;
> }
>
> +u32 qcom_get_dctrl_cfg(struct mmci_host *host)

This can be static.

> +{
> + struct variant_data *variant = host->variant;
> +
> + return variant->datactrl_dpsm_enable | (host->data->blksz << 4);
> +}
> +
> static struct mmci_host_ops qcom_variant_ops = {
> .prep_data = mmci_dmae_prep_data,
> .unprep_data = mmci_dmae_unprep_data,
> + .get_datactrl_cfg = qcom_get_dctrl_cfg,
> .get_next_data = mmci_dmae_get_next_data,
> .dma_setup = qcom_dma_setup,
> .dma_release = mmci_dmae_release,
> --
> 2.7.4
>

Kind regards
Uffe