Re: [PATCH] x86/KASLR: always return a value from process_mem_region

From: Louis Taylor
Date: Wed Mar 06 2019 - 15:38:22 EST


On Wed, Mar 06, 2019 at 09:02:47PM +0100, Thomas Gleixner wrote:
> On Sat, 2 Mar 2019, Louis Taylor wrote:
>
> > When compiling with -Wreturn-type, clang warns:
> >
> > arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
> > non-void function [-Wreturn-type]
> >
> > This function's return statement should probably have been placed
> > outside the #endif, so move it there
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/360
> > Signed-off-by: Louis Taylor <louis@xxxxxxxxxx>
>
> This lacks a
>
> Fixes: commitsha1 (".....")

Fixes: 690eaa532057 ("x86/boot/KASLR: Limit KASLR to extract the kernel in immovable memory only")

Would you like me to resend with that tag?

Cheers,
Louis