Re: [PATCH] kbuild: add workaround for Debian make-kpkg
From: Masahiro Yamada
Date: Wed Mar 06 2019 - 23:04:13 EST
On Thu, Mar 7, 2019 at 6:02 AM Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> [Trying again with an alternate address for Manoj.]
> kernel-package is maintained by Manoj Srivastava (cc'd), not by the
> Debian kernel team.
> On Thu, 2019-03-07 at 01:00 +0900, Masahiro Yamada wrote:
> > Since commit 3812b8c5c5d5 ("kbuild: make -r/-R effective in top
> > Makefile for old Make versions"), make-kpkg is not working.
> > make-kpkg directly includes the top Makefile of Linux kernel, and
> > appends some debian_* targets.
> > /usr/share/kernel-package/ruleset/kernel_version.mk:
> > # Include the kernel makefile
> > override dot-config := 1
> > include Makefile
> > dot-config := 1
> > I did not know the kernel Makefile was used in that way, and it is
> > hard to guarantee the behavior when the kernel Makefile is included
> > by another Makefile from a different project.
> > Looks like Debian Stretch stopped providing make-kpkg (except
> > PowerPC).
> kernel-package is not included in stretch at all. I'm not sure where
> you're seeing it as being present on powerpc - that architecture wasn't
> included in the stretch release.
Actually, I have not checked the powerpc part by myself.
I just read the following page:
"make-kpkg is included in wheezy and jessie but stretch (current
stable) only contains it for powerpc.
Powerpc is no longer supported in buster (testing)"
I will drop the PowerPC part.
> > Maybe it is obsolete and being replaced with 'make deb-pkg' etc.
> > but still widely used.
> kernel-package is currently planned to be included in the next release,
> though I'm not sure whether it should be.
I checked debian:buster in Docker,
and I see it.
root@3382de16960a:/home/foo# apt-file search make-kpkg
If make-kpkg will still be included in the future Debian releases,
I'd like to change make-kpkg to make it work more reliably.
The git URL in the control file
Anyway, I found it in a new place:
$ git clone https://salsa.debian.org/srivasta/kernel-package
Hmm, the last commit was three years ago.
So, it is almost unmaintained, I guess...
> There is another bug report about kernel-package with current kernel
> versions <https://bugs.debian.org/890817> but I don't know whether it
> has been worked around already.
Probably, not fixed.
It is not stalled actually.
I guess make-kpkg is hiding messages sent to stdout for some reasons.
If you continue pressing "Enter" key,
it will move on to the build stage.
I will take a look if it should be maintained.
Anyway, I want to hear from Manoj.