Re: [PATCH net] rxrpc: Fix client call queueing, waiting for channel
From: David Miller
Date: Fri Mar 08 2019 - 21:25:41 EST
From: David Howells <dhowells@xxxxxxxxxx>
Date: Sat, 09 Mar 2019 00:29:58 +0000
> rxrpc_get_client_conn() adds a new call to the front of the waiting_calls
> queue if the connection it's going to use already exists. This is bad as
> it allows calls to get starved out.
> Fix this by adding to the tail instead.
> Also change the other enqueue point in the same function to put it on the
> front (ie. when we have a new connection). This makes the point that in
> the case of a new connection the new call goes at the front (though it
> doesn't actually matter since the queue should be unoccupied).
> Fixes: 45025bceef17 ("rxrpc: Improve management and caching of client connection objects")
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
Applied and queued up for -stable, thanks David.