Re: [PATCH 3/4] iommu/vt-d: Allow IOMMU_DOMAIN_DMA and IOMMU_DOMAIN_IDENTITY to be allocated

From: James Sewart
Date: Sat Mar 09 2019 - 06:58:46 EST


Hey Dmitry,

> On 8 Mar 2019, at 01:20, Dmitry Safonov <dima@xxxxxxxxxx> wrote:
>
> On 3/4/19 3:46 PM, James Sewart wrote:
>> +static inline int domain_is_initialised(struct dmar_domain *domain)
>> +{
>> + return domain->flags & DOMAIN_FLAG_INITIALISED;
>> +}
>
> Maybe check it in intel_iommu_domain_free(), eh?

Good shout, freeing a non attached IOMMU_DOMAIN_DMA domain is now
different to an attached one.

>
> Thanks,
> Dmitry


Cheers,
James.