Re: [PATCH] net: lan9303: fix missing error handling
From: David Miller
Date: Sun Mar 10 2019 - 14:00:51 EST
From: Kangjie Lu <kjlu@xxxxxxx>
Date: Sun, 10 Mar 2019 03:08:56 -0500
> Both lan9303_phy_write and regmap_write may fail. The fix adds
> the error handling to print error messages upon failure.
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
It's ignored elsewhere in this driver in places you haven't handled.
I doubt this is much of an improvement to the driver to be quite
I disagree with the mantra that just because an error is potentially
returned, that it always must be checked.