Re: [RFC PATCH v1 25/25] printk: remove unused code
From: Sebastian Andrzej Siewior
Date: Mon Mar 11 2019 - 04:19:18 EST
On 2019-03-11 11:46:00 [+0900], Sergey Senozhatsky wrote:
> On (03/08/19 15:02), Sebastian Andrzej Siewior wrote:
> > On 2019-02-12 15:30:03 [+0100], John Ogness wrote:
> > you removed the whole `irq_work' thing. You can also remove the include
> > for linux/irq_work.h.
> It may be too early to remove the whole `irq_work' thing.
> printk()->call_console_driver() should take console_sem
I would be _very_ glad to see that irq_work thingy gone. I just stumbled
upon this irq_work and cursed a little while doing other things.
Checking John's series and seeing that it was gone, was a relief.
Printing the whole thing in irq context does not look sane. printing the
import things right away and printing the remaining things later in
kthread looks good to me.