Re: [PATCH] vmlinux.lds.h: drop unused __vermagic

From: Arnd Bergmann
Date: Mon Mar 11 2019 - 08:11:43 EST


On Mon, Mar 11, 2019 at 12:55 PM Jessica Yu <jeyu@xxxxxxxxxx> wrote:
>
> +++ Mathias Krause [10/03/19 20:26 +0100]:
> >Hi Jessica,
> >
> >On Mon, 21 Jan 2019 at 12:39, Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote:
> >>
> >> On Wed, 2 Jan 2019 at 21:29, Jessica Yu <jeyu@xxxxxxxxxx> wrote:
> >> >
> >> > +++ Mathias Krause [30/12/18 13:40 +0100]:
> >> > >The reference to '__vermagic' is a relict from v2.5 times. And even
> >> > >there it had a very short life time, from v2.5.59 (commit 1d411b80ee18
> >> > >("Module Sanity Check") in the historic tree) to v2.5.69 (commit
> >> > >67ac5b866bda ("[PATCH] complete modinfo section")).
> >> > >
> >> > >Neither current kernels nor modules contain a '__vermagic' section any
> >> > >more, so get rid of it.
> >> > >
> >> > >Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> >> > >Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> >> > >Cc: Jessica Yu <jeyu@xxxxxxxxxx>
> >> >
> >> > Thanks for the cleanup.
> >> >
> >> > Reviewed-by: Jessica Yu <jeyu@xxxxxxxxxx>
> >> >
> >>
> >> Arnd, will you carry this patch through your asm-generic tree or did
> >> the MAINTAINERS file mislead me here?
> >>
> >
> >looks like Arnd keeps ignoring my Emails. :/ Can you carry this patch
> >through your module tree? Or do you think I should ask Andrew Morton
> >instead?

Oops, sorry about this.

> Sure, I'll queue this up in modules-next shortly after the merge window.

Ok, thanks for picking it up!

Arnd