Re: [PATCH v2] f2fs: fix to check inline_xattr_size boundary correctly
From: Jaegeuk Kim
Date: Tue Mar 12 2019 - 22:03:28 EST
On 03/13, Chao Yu wrote:
> On 2019/3/13 2:50, Jaegeuk Kim wrote:
> > On 03/04, Chao Yu wrote:
> >> Hi Jaegeuk,
> >> On 2019/2/15 0:08, Chao Yu wrote:
> >>> ---
> >>> v2:
> >>> - fix lower bound check, inline xattr size should be larger than
> >>> xattr_header's size at least.
> >> ...
> >>> + if (F2FS_OPTION(sbi).inline_xattr_size <
> >>> + sizeof(struct f2fs_xattr_header) / sizeof(__le32)
> >> No sure we should set this low bound as above... now I guess original
> >> non-zero check is enough.
> >> How do you think of setting inline_xattr_size range as
> >> (0, MAX_INLINE_XATTR_SIZE]?
> > How about this?
> If you think it's necessary to check low bound with size of xattr header,
> I'm also okay with that.
> And below diff looks good to me, could you please merge this into original one?
I had to add this on top of branch.