Re: [PATCH v5 1/2] media: uapi: Add H264 low-level decoder API compound controls.
From: Maxime Ripard
Date: Wed Mar 13 2019 - 11:31:38 EST
On Fri, Mar 08, 2019 at 03:12:18PM +0900, Tomasz Figa wrote:
> > +.. _v4l2-mpeg-h264:
> > +
> > +``V4L2_CID_MPEG_VIDEO_H264_SPS (struct)``
> > + Specifies the sequence parameter set (as extracted from the
> > + bitstream) for the associated H264 slice data. This includes the
> > + necessary parameters for configuring a stateless hardware decoding
> > + pipeline for H264. The bitstream parameters are defined according
> > + to :ref:`h264`. Unless there's a specific comment, refer to the
> > + specification for the documentation of these fields, section 184.108.40.206.1
> > + "Sequence Parameter Set Data Semantics".
> I don't see this section being added by this patch. Where does it come from?
This is referring to the the H264 spec itself, as I was trying to
point out with the reference in that paragraph. How would you write
this down to make it more obvious?
> > +.. c:type:: v4l2_ctrl_h264_decode_param
> > +
> > +.. cssclass:: longtable
> > +
> > +.. flat-table:: struct v4l2_ctrl_h264_decode_param
> > + :header-rows: 0
> > + :stub-columns: 0
> > + :widths: 1 1 2
> > +
> > + * - __u32
> > + - ``num_slices``
> > + - Number of slices needed to decode the current frame
> > + * - __u16
> > + - ``idr_pic_flag``
> > + - Is the picture an IDR picture?
> Sounds like this could be made a flag to be consistent with how this
> kind of fields are represented in the other structs.
I'll change that, thanks!
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
Description: PGP signature