Re: [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop

From: Mark Salter
Date: Wed Mar 13 2019 - 13:22:09 EST


On Mon, 2019-03-11 at 22:47 +0000, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@xxxxxxx>
> Cc: Mark Salter <msalter@xxxxxxxxxx>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@xxxxxxxxx>
> Cc: linux-c6x-dev@xxxxxxxxxxxxx
> ---
> arch/c6x/kernel/entry.S | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 2721c90b0121..17926e942edb 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -567,7 +567,6 @@ resume_kernel:
> NOP 4
> [A1] BNOP .S2 restore_all,5
>
> -preempt_schedule:
> GET_THREAD_INFO A2
> LDW .D1T1 *+A2(THREAD_INFO_FLAGS),A1
> #ifdef CONFIG_C6X_BIG_KERNEL
> @@ -584,7 +583,7 @@ preempt_schedule:
> #else
> B .S2 preempt_schedule_irq
> #endif
> - ADDKPC .S2 preempt_schedule,B3,4
> + ADDKPC .S2 restore_all,B3,4
> #endif /* CONFIG_PREEMPT */
>
> ENTRY(enable_exception)

Acked-by: Mark Salter <msalter@xxxxxxxxxx>