Re: [PATCH v2 4/5] slob: Use slab_list instead of lru

From: Tobin C. Harding
Date: Wed Mar 13 2019 - 23:24:50 EST


On Wed, Mar 13, 2019 at 07:05:02PM +0000, Christopher Lameter wrote:
> On Wed, 13 Mar 2019, Tobin C. Harding wrote:
>
> > @@ -297,7 +297,7 @@ static void *slob_alloc(size_t size, gfp_t gfp, int align, int node)
> > continue;
> >
> > /* Attempt to alloc */
> > - prev = sp->lru.prev;
> > + prev = sp->slab_list.prev;
> > b = slob_page_alloc(sp, size, align);
> > if (!b)
> > continue;
>
> Hmmm... Is there a way to use a macro or so to avoid referencing the field
> within the slab_list?

Thanks for the review. Next version includes a fix for this.

Tobin.