Re: [PATCH v2] appletalk: Fix potential NULL pointer dereference in unregister_snap_client

From: David Miller
Date: Fri Mar 15 2019 - 14:26:18 EST


From: Yue Haibing <yuehaibing@xxxxxxxxxx>
Date: Thu, 14 Mar 2019 13:47:59 +0800

> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> register_snap_client may return NULL, all the callers
> check it, but only print a warning. This will result in
> NULL pointer dereference in unregister_snap_client and other
> places.
>
> It has always been used like this since v2.6
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: del timer in aarp_proto_init error patch

Applied, thanks for following up.