Re: KASAN: slab-out-of-bounds Read in tick_sched_handle

From: Stefano Brivio
Date: Sat Mar 16 2019 - 12:23:08 EST


On Sat, 16 Mar 2019 17:07:13 +0100
Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:

> On Sat, Mar 16, 2019 at 4:53 PM Stefano Brivio <sbrivio@xxxxxxxxxx> wrote:
> >
> > On Sat, 16 Mar 2019 07:49:01 -0700
> > syzbot <syzbot+09d51a30df9fe76edb2a@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > syzbot has bisected this bug to:
> > >
> > > commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> > > Author: Stefano Brivio <sbrivio@xxxxxxxxxx>
> > > Date: Thu Nov 8 11:19:23 2018 +0000
> > >
> > > fou, fou6: ICMP error handlers for FoU and GUE
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16f943e7200000
> > > start commit: b8a51b38 fou, fou6: ICMP error handlers for FoU and GUE
> > > git tree: upstream
> > > final crash: https://syzkaller.appspot.com/x/report.txt?x=15f943e7200000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=11f943e7200000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=09d51a30df9fe76edb2a
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17359fab400000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=154a2a37400000
> > >
> > > Reported-by: syzbot+09d51a30df9fe76edb2a@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > Fixes: b8a51b38 ("fou, fou6: ICMP error handlers for FoU and GUE")
> >
> > Might be fixed by bc6e019b6ee6 ("fou: Prevent unbounded recursion in GUE
> > error handler also with UDP-Lite"), testing/checking now.
>
> Yes, most likely it is. The bug was just never closed as fixed. But
> the last crash happened 2 months ago.
> So I would say we just mark this as fixed:
>
> #syz fix:
> fou: Prevent unbounded recursion in GUE error handler also with UDP-Lite

Confirmed by testing, too.

> Next after root cause bisection is fix bisection, so this part will be
> automated to some degree as well.

Nice, thanks for doing that.

--
Stefano